feat: support grpc json protocol #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add client conf - support json codec Closes apache#436
|
@relaxedCat pls add comment for the public structs/funcs. |
AlexStocks
requested review from
zouyx,
fangyincheng and
AlexStocks
and removed request for
zouyx
|
Travis still failing |
zouyx
reviewed
Jun 6, 2020
AlexStocks
reviewed
Jun 6, 2020
relaxedCat
force-pushed
the
feat-grpc-json
branch
3 times, most recently
from
97547bd
to
7530503
Compare
Codecov Report
@@ Coverage Diff @@
## develop #582 +/- ##
===========================================
- Coverage 67.20% 67.12% -0.09%
===========================================
Files 174 190 +16
Lines 9261 9918 +657
===========================================
+ Hits 6224 6657 +433
- Misses 2432 2605 +173
- Partials 605 656 +51
Continue to review full report at Codecov.
|
relaxedCat
force-pushed
the
feat-grpc-json
branch
from
7530503
to
2b8cbe4
Compare
|
Pls add comments for funcs/stucts. |
relaxedCat
force-pushed
the
feat-grpc-json
branch
from
2b8cbe4
to
1614725
Compare
relaxedCat
force-pushed
the
feat-grpc-json
branch
from
1614725
to
9dc28f0
Compare
done. |
zouyx
reviewed
Jun 9, 2020
AlexStocks
reviewed
Jun 13, 2020
protocol/grpc/client.go
Outdated
| // load clientconfig from consumer_config | ||
| // default use grpc | ||
| defaultClientConfig := GetDefaultClientConfig() | ||
| clientConf = &defaultClientConfig |
There was a problem hiding this comment.
the above two line codes is very strange. why now define a NewDefaultClientConfig() *ClientConfig?
There was a problem hiding this comment.
ok,use defer delay check instead
zouyx
approved these changes
Jun 13, 2020
relaxedCat
force-pushed
the
feat-grpc-json
branch
from
69b4eb3
to
45a983e
Compare
AlexStocks
approved these changes
Jun 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #437 comment