[fix](auditlog) add missing audit log fields and duplicate audit log error #42262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
morningman
force-pushed
the
audit_log_fix
branch
3 times, most recently
from
d8dfde3 to
88f6f3e
Compare
morningman
changed the title
morningman
force-pushed
the
audit_log_fix
branch
from
b0811f1 to
a3326fe
Compare
|
run buildall |
yiguolei
previously approved these changes
Oct 31, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
approved
|
PR approved by anyone and no changes requested. |
morningman
force-pushed
the
audit_log_fix
branch
from
8cd874e to
a15944e
Compare
|
run buildall |
github-actions
bot
removed
the
approved
|
run buildall |
|
run buildall |
morningman
added a commit
that referenced
this pull request
Nov 1, 2024
morningman
force-pushed
the
audit_log_fix
branch
from
e6090a9 to
c267ab4
Compare
|
run buildall |
|
run buildall |
|
run buildall |
morningman
force-pushed
the
audit_log_fix
branch
from
d7705a1 to
0fb215d
Compare
|
run buildall |
wuwenchi
approved these changes
Nov 2, 2024
CalvinKirs
approved these changes
Nov 2, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
github-actions bot
pushed a commit
that referenced
this pull request
Nov 2, 2024
…error (#42262) ### What problem does this PR solve? Problem Summary: #### Issue 1 There are some fields that is missing in audit log table. This PR add them all: - shuffle_send_rows - shuffle_send_bytes - scan_bytes_from_local_storage - scan_bytes_from_remote_storage - is_nereids - compute_group Notice that `compute_group` is previously name `cloudClusterName` in fe.audit.log, which is incorrect, so I change it to the right name. After this PR, all these fields will be saved in both audit log table and fe.audit.log #### Issue 2 The `AuditEventBuilder` need to be reset at each run, the there will be duplicate audit log. #### Issue 3 Add a new statement `call flush_audit_log()`. It will flush the audit log immediately to audit_log table. This is useful in test case, so that we don't need to wait 1min to flush the audit log data. ### Release note [fix](auditlog) add missing audit log fields and duplicate audit log error
Closed
16 tasks
16 tasks
morningman
added a commit
to morningman/doris
that referenced
this pull request
Nov 6, 2024
…error (apache#42262) ### What problem does this PR solve? Problem Summary: #### Issue 1 There are some fields that is missing in audit log table. This PR add them all: - shuffle_send_rows - shuffle_send_bytes - scan_bytes_from_local_storage - scan_bytes_from_remote_storage - is_nereids - compute_group Notice that `compute_group` is previously name `cloudClusterName` in fe.audit.log, which is incorrect, so I change it to the right name. After this PR, all these fields will be saved in both audit log table and fe.audit.log #### Issue 2 The `AuditEventBuilder` need to be reset at each run, the there will be duplicate audit log. #### Issue 3 Add a new statement `call flush_audit_log()`. It will flush the audit log immediately to audit_log table. This is useful in test case, so that we don't need to wait 1min to flush the audit log data. ### Release note [fix](auditlog) add missing audit log fields and duplicate audit log error
morningman
added a commit
that referenced
this pull request
Nov 6, 2024
### What problem does this PR solve? Problem Summary: 1. add some missing output blocks for `test_audit_log_behavior.out` 2. `call flush_audit_log()` does not support old planner, add check for it. followup #42262
morningman
added a commit
to morningman/doris
that referenced
this pull request
Nov 6, 2024
### What problem does this PR solve? Problem Summary: 1. add some missing output blocks for `test_audit_log_behavior.out` 2. `call flush_audit_log()` does not support old planner, add check for it. followup apache#42262
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Issue 1
There are some fields that is missing in audit log table.
This PR add them all:
Notice that
compute_groupis previously namecloudClusterNamein fe.audit.log,which is incorrect, so I change it to the right name.
After this PR, all these fields will be saved in both audit log table and fe.audit.log
Issue 2
The
AuditEventBuilderneed to be reset at each run, the there will be duplicate audit log.Issue 3
Add a new statement
call flush_audit_log(). It will flush the audit log immediately to audit_log table.This is useful in test case, so that we don't need to wait 1min to flush the audit log data.
Check List (For Committer)
Test
Behavior changed:
cloudClusterNamein fe.audit.log change tocomputeGroup. And some fields are added to the audit log table.Does this need documentation?
Release note
fix add missing audit log fields and duplicate audit log error
Check List (For Reviewer who merge this PR)