Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](resize)fix array/map resize impl missing data resize #41708

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[fix](resize)fix array/map resize impl missing data resize #41708

merged 2 commits into from
Oct 15, 2024

Conversation

amorynan
Copy link
Contributor

Proposed changes

backport: #41595
Issue Number: close #xxx

@amorynan
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (8147/21549)
Line Coverage: 29.54% (67060/226994)
Region Coverage: 29.01% (34561/119129)
Branch Coverage: 24.93% (17808/71442)
Coverage Report: http://coverage.selectdb-in.cc/coverage/45d6b44c37f99f347d87d0d04587e3c891fea6be_45d6b44c37f99f347d87d0d04587e3c891fea6be/report/index.html

xiaokang
xiaokang reviewed Oct 12, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pick unit test

@xiaokang xiaokang changed the title [fix](resize)fix array/map resize imp; [fix](resize)fix array/map resize impl Oct 12, 2024
@xiaokang xiaokang changed the title [fix](resize)fix array/map resize impl [fix](resize)fix array/map resize impl missing data resize Oct 12, 2024
@amorynan
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.83% (8152/21549)
Line Coverage: 29.56% (67100/227004)
Region Coverage: 29.03% (34588/119139)
Branch Coverage: 24.98% (17850/71450)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f0a94db28c6118651dff17524154ff5faf67587a_f0a94db28c6118651dff17524154ff5faf67587a/report/index.html

@amorynan
Copy link
Contributor Author

pick unit test

rewrite a new test for resize

eldenmoon
eldenmoon approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@eldenmoon eldenmoon merged commit 3463807 into apache:branch-2.0 Oct 15, 2024
20 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaokang xiaokang xiaokang left review comments

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. kind/test reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amorynan @doris-robot @xiaokang @eldenmoon