Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Variant) check enable light_schema_change when create table with variant type #40908

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[fix](Variant) check enable light_schema_change when create table with variant type #40908

merged 1 commit into from
Sep 23, 2024

Conversation

eldenmoon
Copy link
Member

No description provided.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon
Copy link
Member Author

run buildall

@eldenmoon eldenmoon added dev/2.0.x dev/2.1.x dev/3.0.x usercase Important user case type label and removed dev/2.0.x labels Sep 18, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 41719 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0dad228e81f12318796e12532d68603801018143, data reload: false

------ Round 1 ----------------------------------
q1	17569	7387	7278	7278
q2	2058	158	152	152
q3	10600	1102	1158	1102
q4	10524	728	837	728
q5	7760	3118	3132	3118
q6	237	155	148	148
q7	1005	617	602	602
q8	9428	2045	2078	2045
q9	6855	6445	6441	6441
q10	6996	2294	2296	2294
q11	435	247	245	245
q12	411	222	214	214
q13	17790	2976	2993	2976
q14	254	214	218	214
q15	578	509	521	509
q16	681	608	610	608
q17	972	787	803	787
q18	7354	6655	6843	6655
q19	1411	1070	1069	1069
q20	586	279	278	278
q21	4012	3288	3262	3262
q22	1093	1028	994	994
Total cold run time: 108609 ms
Total hot run time: 41719 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7394	7333	7354	7333
q2	322	238	226	226
q3	3071	3024	2983	2983
q4	2083	1856	1825	1825
q5	5649	5686	5736	5686
q6	237	148	154	148
q7	2246	1816	1804	1804
q8	3355	3457	3453	3453
q9	8868	9088	9153	9088
q10	3513	3587	3633	3587
q11	594	497	534	497
q12	845	623	672	623
q13	12149	3249	3273	3249
q14	308	271	283	271
q15	598	565	543	543
q16	727	690	681	681
q17	1807	1604	1626	1604
q18	8143	7962	7733	7733
q19	1744	1582	1514	1514
q20	2117	1910	1886	1886
q21	5704	5524	5303	5303
q22	1151	1096	1028	1028
Total cold run time: 72625 ms
Total hot run time: 61065 ms

@doris-robot
Copy link

TPC-H: Total hot run time: 41904 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0dad228e81f12318796e12532d68603801018143, data reload: false

------ Round 1 ----------------------------------
q1	18783	7461	7359	7359
q2	2059	165	157	157
q3	10890	1138	1219	1138
q4	10819	721	685	685
q5	7776	3095	3084	3084
q6	236	152	149	149
q7	1007	622	602	602
q8	10363	2053	2087	2053
q9	7066	6484	6503	6484
q10	7114	2284	2319	2284
q11	451	255	256	255
q12	414	216	219	216
q13	18324	3171	3144	3144
q14	261	232	238	232
q15	575	551	550	550
q16	1622	632	616	616
q17	1179	796	800	796
q18	7271	6738	6717	6717
q19	1620	980	941	941
q20	575	309	278	278
q21	4383	3159	3217	3159
q22	1117	1017	1005	1005
Total cold run time: 113905 ms
Total hot run time: 41904 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7243	7241	7331	7241
q2	339	229	238	229
q3	3103	2919	2944	2919
q4	2088	1812	1787	1787
q5	5543	5543	5745	5543
q6	230	148	145	145
q7	2186	1832	1819	1819
q8	3288	3420	3402	3402
q9	8922	8853	8827	8827
q10	3435	3483	3483	3483
q11	584	490	491	490
q12	825	637	641	637
q13	11508	3178	3157	3157
q14	303	281	279	279
q15	585	526	531	526
q16	725	665	689	665
q17	1798	1599	1621	1599
q18	8163	7805	7800	7800
q19	1740	1699	1518	1518
q20	2108	1874	1880	1874
q21	5580	5303	5422	5303
q22	1178	1056	1063	1056
Total cold run time: 71474 ms
Total hot run time: 60299 ms

@xiaokang xiaokang changed the title [opt](Variant) check enable light_schema_change when create table with variant type [fix](Variant) check enable light_schema_change when create table with variant type Sep 21, 2024
xiaokang
xiaokang approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

qidaye
qidaye approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eldenmoon eldenmoon merged commit 5214e6b into apache:master Sep 23, 2024
27 of 30 checks passed
@eldenmoon eldenmoon deleted the ck-var-lsc branch September 23, 2024 02:19
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Sep 23, 2024
@eldenmoon
[fix](Variant) check enable light_schema_change when create table wit…
a3ddcb0 
…h variant type (apache#40908)
@eldenmoon eldenmoon mentioned this pull request Sep 23, 2024
Merged
eldenmoon added a commit that referenced this pull request Sep 23, 2024
@eldenmoon
[pick](Variant) check enable light_schema_change when create table wi…
76d62c4 
…th variant type (#41102)

#40908
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
@eldenmoon @dataroaring
[fix](Variant) check enable light_schema_change when create table wit…
6d08913 
…h variant type (#40908)
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Open
@gavinchou gavinchou mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qidaye qidaye qidaye approved these changes

@xiaokang xiaokang xiaokang approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged dev/3.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldenmoon @doris-robot @xiaokang @qidaye @dataroaring