-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug](partition_topn) fix partition_topn not reset output rows after do_partition_topn_sort #40761
Conversation
…do_partition_topn_sort
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 43020 ms
|
TPC-H: Total hot run time: 43060 ms
|
TPC-DS: Total hot run time: 196225 ms
|
ClickBench: Total hot run time: 31.59 s
|
run buildall |
TPC-H: Total hot run time: 43077 ms
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 194699 ms
|
ClickBench: Total hot run time: 30.92 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
…do_partition_topn_sort (#40761) ## Proposed changes should reset all variables about output rows after do_partition_topn_sort and get_next from sorter if we not reset all variables. it's will be regard as have output many rows but the sorter still have remaing many data need to output. <!--Describe your changes.-->
Proposed changes
should reset all variables about output rows after do_partition_topn_sort and get_next from sorter
if we not reset all variables. it's will be regard as have output many rows
but the sorter still have remaing many data need to output.