Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](encrypt) wrong mode arg of encrypt and decrypt function make BE crash #40726

Merged
merged 1 commit into from
Sep 14, 2024
Merged

[fix](encrypt) wrong mode arg of encrypt and decrypt function make BE crash #40726

merged 1 commit into from
Sep 14, 2024

Conversation

cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Sep 12, 2024 •
edited
Loading

Not supported mode arg in sm4_encrypt and sm4_decrypt make BE crash.

Intro by #37194

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

run buildall

@wm1581066 wm1581066 added the p0_c label Sep 12, 2024
@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.90% (9456/25629)
Line Coverage: 28.26% (77814/275309)
Region Coverage: 27.66% (40161/145197)
Branch Coverage: 24.27% (20410/84084)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ddee0e714576013726752f725be7ddf56cfb7a53_ddee0e714576013726752f725be7ddf56cfb7a53/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 39767 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ddee0e714576013726752f725be7ddf56cfb7a53, data reload: false

------ Round 1 ----------------------------------
q1	17603	4290	4214	4214
q2	2051	190	183	183
q3	10464	1227	1372	1227
q4	10515	967	1001	967
q5	7721	3190	3182	3182
q6	226	142	137	137
q7	1053	637	624	624
q8	9455	2012	2021	2012
q9	6854	6336	6313	6313
q10	7009	2531	2494	2494
q11	425	252	248	248
q12	404	227	224	224
q13	17760	3015	3021	3015
q14	288	252	246	246
q15	543	476	478	476
q16	515	432	427	427
q17	980	946	934	934
q18	7410	6763	6835	6763
q19	1382	1245	1220	1220
q20	616	324	329	324
q21	3893	3531	3547	3531
q22	1090	1006	1013	1006
Total cold run time: 108257 ms
Total hot run time: 39767 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4242	4206	4206	4206
q2	342	231	231	231
q3	2890	2903	2894	2894
q4	1960	1965	1985	1965
q5	5717	5706	5766	5706
q6	228	133	139	133
q7	2125	1814	1757	1757
q8	3343	3399	3409	3399
q9	8835	8854	8892	8854
q10	3507	3625	3637	3625
q11	571	491	494	491
q12	823	607	652	607
q13	8313	3291	3117	3117
q14	322	288	281	281
q15	551	499	505	499
q16	517	452	478	452
q17	1839	1743	1698	1698
q18	8460	8057	8119	8057
q19	1777	1759	1753	1753
q20	2149	1912	1864	1864
q21	5931	5719	5767	5719
q22	1175	1063	984	984
Total cold run time: 65617 ms
Total hot run time: 58292 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 199713 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ddee0e714576013726752f725be7ddf56cfb7a53, data reload: false

query1	1261	875	890	875
query2	6185	1749	1743	1743
query3	10811	4046	4072	4046
query4	55848	25062	23960	23960
query5	5140	538	521	521
query6	355	183	184	183
query7	5693	316	294	294
query8	276	228	227	227
query9	6234	2433	2432	2432
query10	387	293	281	281
query11	16056	15539	15585	15539
query12	156	102	99	99
query13	1458	394	374	374
query14	10521	7143	6771	6771
query15	210	177	181	177
query16	7022	494	520	494
query17	1146	600	601	600
query18	1763	319	305	305
query19	205	159	158	158
query20	130	115	109	109
query21	218	109	108	108
query22	4739	4708	4682	4682
query23	35008	33808	33978	33808
query24	6174	3154	3008	3008
query25	516	415	414	414
query26	609	161	157	157
query27	1565	279	279	279
query28	2797	2034	2007	2007
query29	690	436	429	429
query30	227	160	156	156
query31	989	776	803	776
query32	77	58	57	57
query33	467	308	299	299
query34	879	481	467	467
query35	876	733	788	733
query36	1055	907	932	907
query37	143	87	79	79
query38	3957	4004	3955	3955
query39	1432	1414	1411	1411
query40	208	116	116	116
query41	49	50	47	47
query42	123	99	99	99
query43	470	449	426	426
query44	1152	760	746	746
query45	201	168	168	168
query46	1101	840	820	820
query47	1924	1808	1816	1808
query48	370	289	288	288
query49	744	467	454	454
query50	925	450	437	437
query51	7150	6959	6943	6943
query52	185	88	90	88
query53	257	183	180	180
query54	559	462	464	462
query55	81	77	76	76
query56	288	267	265	265
query57	1232	1095	1090	1090
query58	223	237	251	237
query59	2735	2448	2561	2448
query60	305	276	295	276
query61	106	104	102	102
query62	784	679	673	673
query63	219	189	189	189
query64	1589	674	660	660
query65	3230	3134	3165	3134
query66	673	341	338	338
query67	16029	15691	15900	15691
query68	1863	867	864	864
query69	437	324	329	324
query70	1163	1157	1150	1150
query71	354	343	350	343
query72	6137	3379	3392	3379
query73	588	573	575	573
query74	9106	9096	8867	8867
query75	3077	2977	3047	2977
query76	1011	853	854	853
query77	513	405	400	400
query78	9598	9269	9273	9269
query79	924	893	871	871
query80	847	850	835	835
query81	467	262	268	262
query82	268	263	272	263
query83	192	194	189	189
query84	261	108	105	105
query85	656	443	403	403
query86	332	318	302	302
query87	4403	4343	4399	4343
query88	4134	4052	4058	4052
query89	370	368	369	368
query90	1674	315	306	306
query91	124	124	124	124
query92	79	79	80	79
query93	1057	1049	1042	1042
query94	624	357	381	357
query95	449	420	411	411
query96	467	471	469	469
query97	3140	3184	3190	3184
query98	227	230	229	229
query99	1694	1350	1339	1339
Total cold run time: 292423 ms
Total hot run time: 199713 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.83 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ddee0e714576013726752f725be7ddf56cfb7a53, data reload: false

query1	0.05	0.04	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.06	0.06
query5	0.51	0.51	0.50
query6	1.15	0.73	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.56	0.52	0.51
query10	0.57	0.57	0.57
query11	0.16	0.12	0.12
query12	0.16	0.13	0.13
query13	0.62	0.61	0.61
query14	1.47	1.49	1.48
query15	0.90	0.87	0.87
query16	0.37	0.37	0.37
query17	1.02	1.01	1.00
query18	0.17	0.16	0.16
query19	1.94	1.86	1.85
query20	0.01	0.01	0.02
query21	15.40	0.66	0.65
query22	4.28	7.39	1.10
query23	18.26	1.29	1.35
query24	2.27	0.23	0.22
query25	0.18	0.08	0.08
query26	0.30	0.18	0.18
query27	0.08	0.08	0.08
query28	13.18	1.01	0.98
query29	12.60	3.35	3.34
query30	0.25	0.06	0.05
query31	2.88	0.43	0.42
query32	3.22	0.49	0.50
query33	3.06	3.03	3.06
query34	15.44	4.34	4.30
query35	4.39	4.41	4.37
query36	0.68	0.49	0.49
query37	0.18	0.16	0.16
query38	0.16	0.14	0.14
query39	0.05	0.04	0.04
query40	0.16	0.14	0.14
query41	0.10	0.05	0.05
query42	0.06	0.06	0.04
query43	0.05	0.04	0.04
Total cold run time: 108.94 s
Total hot run time: 30.83 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

zclllyybb
zclllyybb approved these changes Sep 14, 2024
View reviewed changes
Copy link
Contributor

@zclllyybb zclllyybb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lide-reed lide-reed merged commit 6c995e9 into apache:master Sep 14, 2024
25 of 30 checks passed
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Sep 14, 2024
@cambyzju
[fix](encrypt) wrong mode arg of encrypt and decrypt function make BE…
2db6b11 
… crash (apache#40726)

Not supported mode arg in sm4_encrypt and sm4_decrypt make BE crash.

Intro by apache#37194
@cambyzju cambyzju mentioned this pull request Sep 14, 2024
Merged
yiguolei pushed a commit that referenced this pull request Sep 15, 2024
@cambyzju
[fix](encrypt) wrong mode arg of encrypt and decrypt function make BE…
f3b1f1c 
… crash (#40726) (#40868)

pick #40726 to branch-2.1
dataroaring pushed a commit that referenced this pull request Sep 26, 2024
@cambyzju @dataroaring
[fix](encrypt) wrong mode arg of encrypt and decrypt function make BE…
4e9d0fb 
… crash (#40726)

Not supported mode arg in sm4_encrypt and sm4_decrypt make BE crash.

Intro by #37194
@gavinchou gavinchou mentioned this pull request Oct 13, 2024
Open
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged p0_c reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cambyzju @doris-robot @zclllyybb @zhangstar333 @lide-reed @yiguolei @wm1581066 @dataroaring