[fix](mtmv) Disable sql_limit variable when query rewrite by materialize view #40106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 38274 ms |
TPC-DS: Total hot run time: 188309 ms |
ClickBench: Total hot run time: 32.65 s |
|
run buildall |
TPC-H: Total hot run time: 38333 ms |
TPC-DS: Total hot run time: 194014 ms |
ClickBench: Total hot run time: 31.76 s |
|
run buildall |
TPC-H: Total hot run time: 37721 ms |
TPC-DS: Total hot run time: 193727 ms |
ClickBench: Total hot run time: 32.09 s |
seawinde
force-pushed
the
fix_add_limit_wrongly_when_mv
branch
from
6e7ffe0 to
6703ada
Compare
|
run buildall |
TPC-H: Total hot run time: 38279 ms |
TPC-DS: Total hot run time: 187877 ms |
ClickBench: Total hot run time: 31.86 s |
seawinde
force-pushed
the
fix_add_limit_wrongly_when_mv
branch
from
6703ada to
e4abc5f
Compare
|
run buildall |
morrySnow
reviewed
Sep 4, 2024
| @@ -267,7 +269,26 @@ public static Plan rewriteByRules( | |||
| CascadesContext rewrittenPlanContext = CascadesContext.initContext( | |||
| cascadesContext.getStatementContext(), rewrittenPlan, | |||
| cascadesContext.getCurrentJobContext().getRequiredProperties()); | |||
| rewrittenPlan = planRewriter.apply(rewrittenPlanContext); | |||
| // Tmp old disable rule variable | |||
There was a problem hiding this comment.
set disable rules here, not everywhere
TPC-H: Total hot run time: 37746 ms |
TPC-DS: Total hot run time: 193399 ms |
ClickBench: Total hot run time: 33.07 s |
|
run buildall |
TPC-H: Total hot run time: 38420 ms |
TPC-DS: Total hot run time: 186529 ms |
ClickBench: Total hot run time: 32.04 s |
|
run buildall |
TPC-H: Total hot run time: 38262 ms |
seawinde
force-pushed
the
fix_add_limit_wrongly_when_mv
branch
from
099376f to
c0eb449
Compare
|
run buildall |
|
run buildall |
|
run buildall |
|
run buildall |
zddr
reviewed
Oct 10, 2024
| @@ -55,6 +57,9 @@ public static ConnectContext createMTMVContext(MTMV mtmv) { | |||
| ctx.getState().reset(); | |||
| ctx.setThreadLocalInfo(); | |||
| ctx.getSessionVariable().allowModifyMaterializedViewData = true; | |||
| // Disable add default limit rule to avoid refresh data wrong | |||
| ctx.getSessionVariable().setDisableNereidsRules( | |||
There was a problem hiding this comment.
If the default values are changed in the future, there may be issues here. Can we use an additional method
There was a problem hiding this comment.
the default value of disableNereidsRules session should always be empty ''
zddr
approved these changes
Oct 10, 2024
morrySnow
approved these changes
Oct 11, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Oct 21, 2024
…ize view (apache#40106) In BI or some other SQL client，it will set `sql_select_limit` or `default_order_by_limit` session variables automatically. This will make mistake when query rewrite by materialized view, Because after query rewrite by materialized view, the rewritten plan would be optimized by rules again which should add limit on SQL. This pr fix this.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Oct 23, 2024
…ize view (apache#40106) In BI or some other SQL client，it will set `sql_select_limit` or `default_order_by_limit` session variables automatically. This will make mistake when query rewrite by materialized view, Because after query rewrite by materialized view, the rewritten plan would be optimized by rules again which should add limit on SQL. This pr fix this.
seawinde
added a commit
to seawinde/doris
that referenced
this pull request
Oct 23, 2024
…ize view (apache#40106) In BI or some other SQL client，it will set `sql_select_limit` or `default_order_by_limit` session variables automatically. This will make mistake when query rewrite by materialized view, Because after query rewrite by materialized view, the rewritten plan would be optimized by rules again which should add limit on SQL. This pr fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In BI or some other SQL client，it will set
sql_select_limitordefault_order_by_limitsession variables automatically.This will make mistake when query rewrite by materialized view, Because after query rewrite by materialized view, the rewritten plan would be optimized by rules again which should add limit on SQL.
This pr fix this.