Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[function](feature) Implement CRC32 function #38204

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

Gabriel39
Copy link
Contributor

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Gabriel39
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40088 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6c7f9e41ca5882f508556275d873a9d64b13ecf2, data reload: false

------ Round 1 ----------------------------------
q1	18921	4425	4404	4404
q2	2474	211	193	193
q3	11314	1184	1167	1167
q4	10239	806	715	715
q5	8009	2744	2701	2701
q6	231	143	139	139
q7	960	605	592	592
q8	9230	2067	2084	2067
q9	8655	6577	6555	6555
q10	8882	3812	3734	3734
q11	467	242	241	241
q12	392	229	217	217
q13	17769	2962	2981	2962
q14	269	251	231	231
q15	528	482	485	482
q16	488	391	403	391
q17	969	638	700	638
q18	8079	7455	7488	7455
q19	6623	1418	1405	1405
q20	710	327	336	327
q21	4948	3184	3272	3184
q22	361	295	288	288
Total cold run time: 120518 ms
Total hot run time: 40088 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4403	4345	4260	4260
q2	383	282	274	274
q3	3015	2740	2772	2740
q4	1933	1654	1605	1605
q5	5338	5320	5300	5300
q6	218	128	131	128
q7	2071	1756	1749	1749
q8	3204	3340	3298	3298
q9	8440	8405	8340	8340
q10	3856	3747	3724	3724
q11	617	488	494	488
q12	801	614	610	610
q13	16693	2944	2970	2944
q14	300	290	272	272
q15	521	468	488	468
q16	468	424	422	422
q17	1768	1468	1456	1456
q18	7617	7463	7430	7430
q19	1651	1626	1439	1439
q20	1993	1786	1793	1786
q21	4771	4800	4648	4648
q22	592	519	545	519
Total cold run time: 70653 ms
Total hot run time: 53900 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173573 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6c7f9e41ca5882f508556275d873a9d64b13ecf2, data reload: false

query1	921	366	367	366
query2	6447	1876	1849	1849
query3	6661	211	222	211
query4	28453	17570	17299	17299
query5	4192	478	494	478
query6	260	181	168	168
query7	4594	287	287	287
query8	240	198	193	193
query9	8644	2457	2443	2443
query10	445	293	278	278
query11	10507	10131	10234	10131
query12	136	85	87	85
query13	1654	376	377	376
query14	10246	7425	7684	7425
query15	225	167	170	167
query16	7615	506	508	506
query17	1568	533	524	524
query18	1832	283	300	283
query19	199	148	151	148
query20	94	85	82	82
query21	212	126	122	122
query22	4548	4167	4156	4156
query23	33957	32970	33118	32970
query24	11027	2864	2936	2864
query25	629	381	369	369
query26	1567	148	147	147
query27	2921	269	273	269
query28	7457	1997	1988	1988
query29	993	624	607	607
query30	280	150	147	147
query31	972	735	746	735
query32	93	56	54	54
query33	765	333	317	317
query34	890	469	488	469
query35	847	709	715	709
query36	1088	980	936	936
query37	180	83	80	80
query38	2874	2770	2756	2756
query39	857	799	828	799
query40	269	124	120	120
query41	48	44	43	43
query42	127	101	108	101
query43	507	464	464	464
query44	1229	711	709	709
query45	192	162	161	161
query46	1091	728	718	718
query47	1855	1766	1794	1766
query48	366	290	286	286
query49	1182	409	446	409
query50	783	407	409	407
query51	6783	6631	6644	6631
query52	104	95	97	95
query53	357	288	284	284
query54	988	469	446	446
query55	76	75	75	75
query56	289	271	303	271
query57	1169	1042	1026	1026
query58	254	244	261	244
query59	2974	2628	2648	2628
query60	296	274	278	274
query61	97	95	98	95
query62	860	653	655	653
query63	331	290	290	290
query64	10508	2192	1699	1699
query65	3143	3107	3103	3103
query66	1356	344	334	334
query67	15477	15143	15003	15003
query68	4508	529	528	528
query69	476	337	338	337
query70	1202	1141	1115	1115
query71	399	291	281	281
query72	7072	6050	6007	6007
query73	744	333	329	329
query74	6157	5736	5771	5736
query75	3450	2701	2625	2625
query76	2747	975	895	895
query77	462	303	307	303
query78	11222	9081	8991	8991
query79	2830	511	511	511
query80	2005	487	471	471
query81	573	220	223	220
query82	837	135	143	135
query83	288	172	173	172
query84	272	83	92	83
query85	1433	341	319	319
query86	494	342	301	301
query87	3281	3154	3092	3092
query88	4350	2469	2467	2467
query89	486	376	379	376
query90	1978	193	193	193
query91	133	99	104	99
query92	69	47	48	47
query93	4402	504	486	486
query94	1359	302	289	289
query95	411	320	323	320
query96	622	277	288	277
query97	3189	2992	3068	2992
query98	213	203	189	189
query99	1809	1271	1259	1259
Total cold run time: 289274 ms
Total hot run time: 173573 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6c7f9e41ca5882f508556275d873a9d64b13ecf2, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.22	0.06	0.05
query4	1.68	0.09	0.08
query5	0.50	0.50	0.49
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.54	0.56	0.55
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.59
query14	0.75	0.81	0.85
query15	0.86	0.83	0.81
query16	0.36	0.38	0.37
query17	1.04	1.02	0.99
query18	0.23	0.22	0.22
query19	1.86	1.80	1.79
query20	0.01	0.00	0.00
query21	15.40	0.75	0.66
query22	4.59	7.25	1.77
query23	18.29	1.32	1.21
query24	2.16	0.23	0.25
query25	0.17	0.09	0.08
query26	0.30	0.21	0.23
query27	0.45	0.23	0.22
query28	13.18	1.02	0.99
query29	12.59	3.30	3.35
query30	0.26	0.06	0.05
query31	2.88	0.38	0.39
query32	3.28	0.48	0.46
query33	2.87	2.91	2.91
query34	17.06	4.40	4.39
query35	4.44	4.41	4.37
query36	0.66	0.49	0.46
query37	0.19	0.15	0.15
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.15	0.12	0.13
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.15 s
Total hot run time: 30.6 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 23, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@Gabriel39 Gabriel39 merged commit 78de4ad into apache:master Jul 23, 2024
27 of 30 checks passed
Gabriel39 added a commit to Gabriel39/incubator-doris that referenced this pull request Oct 14, 2024
Gabriel39 added a commit that referenced this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants