From 600ce5347551135414638c66024b3d806f8efd04 Mon Sep 17 00:00:00 2001 From: morrySnow <101034200+morrySnow@users.noreply.github.com> Date: Fri, 22 Sep 2023 11:49:38 +0800 Subject: [PATCH] [fix](planner) ctas should not change any meta of column in source table (#24767) if previous PR #22770. we try to fix incorrect nullable in target table. However we changed nullable info of column in source table unexpectly --- .../apache/doris/analysis/CreateTableAsSelectStmt.java | 6 ++++-- regression-test/suites/ddl_p0/test_ctas.groovy | 10 +++++++--- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java index d3a0f39a8c825d..2cc707b73b3848 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java +++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/CreateTableAsSelectStmt.java @@ -17,6 +17,7 @@ package org.apache.doris.analysis; +import org.apache.doris.catalog.Column; import org.apache.doris.common.ErrorCode; import org.apache.doris.common.ErrorReport; import org.apache.doris.common.UserException; @@ -78,8 +79,9 @@ public void analyze(Analyzer analyzer) throws UserException { Preconditions.checkArgument(outputs.size() == queryStmt.getResultExprs().size()); for (int i = 0; i < outputs.size(); ++i) { if (queryStmt.getResultExprs().get(i).getSrcSlotRef() != null) { - queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn() - .setIsAllowNull(outputs.get(i).isNullable()); + Column columnCopy = new Column(queryStmt.getResultExprs().get(i).getSrcSlotRef().getColumn()); + columnCopy.setIsAllowNull(outputs.get(i).isNullable()); + queryStmt.getResultExprs().get(i).getSrcSlotRef().getDesc().setColumn(columnCopy); } } ArrayList resultExprs = getQueryStmt().getResultExprs(); diff --git a/regression-test/suites/ddl_p0/test_ctas.groovy b/regression-test/suites/ddl_p0/test_ctas.groovy index b77a25829e29ce..954be7ef59e20b 100644 --- a/regression-test/suites/ddl_p0/test_ctas.groovy +++ b/regression-test/suites/ddl_p0/test_ctas.groovy @@ -228,10 +228,14 @@ suite("test_ctas") { sql 'insert into a values(1, \'ww\'), (2, \'zs\');' sql 'insert into b values(1, 22);' - sql 'create table c properties("replication_num"="1") as select a.id, a.name, b.age from a left join b on a.id = b.id;' + sql 'set enable_nereids_planner=false' + + sql 'create table c properties("replication_num"="1") as select b.id, a.name, b.age from a left join b on a.id = b.id;' - String desc = sql 'desc c' - assertTrue(desc.contains('Yes')) + String descC = sql 'desc c' + assertTrue(descC.contains('Yes')) + String descB = sql 'desc b' + assertTrue(descB.contains('No')) } finally { sql 'drop table a' sql 'drop table b'