From aa02f48e55cd1addf679804694f7363438ef27f5 Mon Sep 17 00:00:00 2001 From: jiacai2050 Date: Fri, 24 Feb 2023 11:03:17 +0800 Subject: [PATCH 1/3] make page_filter public --- datafusion/core/src/physical_plan/file_format/parquet.rs | 2 +- .../core/src/physical_plan/file_format/parquet/page_filter.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/datafusion/core/src/physical_plan/file_format/parquet.rs b/datafusion/core/src/physical_plan/file_format/parquet.rs index 1c0ef4de7037..3d6e9b2c17a6 100644 --- a/datafusion/core/src/physical_plan/file_format/parquet.rs +++ b/datafusion/core/src/physical_plan/file_format/parquet.rs @@ -62,7 +62,7 @@ use parquet::file::{metadata::ParquetMetaData, properties::WriterProperties}; use parquet::schema::types::ColumnDescriptor; mod metrics; -mod page_filter; +pub mod page_filter; mod row_filter; mod row_groups; diff --git a/datafusion/core/src/physical_plan/file_format/parquet/page_filter.rs b/datafusion/core/src/physical_plan/file_format/parquet/page_filter.rs index 3aaad0078b49..643910fc241a 100644 --- a/datafusion/core/src/physical_plan/file_format/parquet/page_filter.rs +++ b/datafusion/core/src/physical_plan/file_format/parquet/page_filter.rs @@ -101,7 +101,7 @@ use super::metrics::ParquetFileMetrics; /// So we can entirely skip rows 0->199 and 250->299 as we know they /// can not contain rows that match the predicate. #[derive(Debug)] -pub(crate) struct PagePruningPredicate { +pub struct PagePruningPredicate { predicates: Vec, } From 553b8cdef59adc95ea9ee0e4368f58b130afb02b Mon Sep 17 00:00:00 2001 From: jiacai2050 Date: Fri, 24 Feb 2023 11:08:14 +0800 Subject: [PATCH 2/3] make parquet public --- datafusion/core/src/physical_plan/file_format/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datafusion/core/src/physical_plan/file_format/mod.rs b/datafusion/core/src/physical_plan/file_format/mod.rs index a03b3681a46d..bd080f52235d 100644 --- a/datafusion/core/src/physical_plan/file_format/mod.rs +++ b/datafusion/core/src/physical_plan/file_format/mod.rs @@ -24,7 +24,7 @@ mod csv; mod delimited_stream; mod file_stream; mod json; -mod parquet; +pub mod parquet; pub(crate) use self::csv::plan_to_csv; pub use self::csv::CsvExec; From ec101d29764b301d817d02cacbe2c0014b1ed571 Mon Sep 17 00:00:00 2001 From: jiacai2050 Date: Thu, 8 Jun 2023 15:31:05 +0800 Subject: [PATCH 3/3] fix CI --- datafusion/core/src/datasource/physical_plan/parquet.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/datafusion/core/src/datasource/physical_plan/parquet.rs b/datafusion/core/src/datasource/physical_plan/parquet.rs index e9c14d9590bf..48e4d4937170 100644 --- a/datafusion/core/src/datasource/physical_plan/parquet.rs +++ b/datafusion/core/src/datasource/physical_plan/parquet.rs @@ -612,12 +612,14 @@ pub trait ParquetFileReaderFactory: Debug + Send + Sync + 'static { ) -> Result>; } +/// Default parquet reader factory. #[derive(Debug)] pub struct DefaultParquetFileReaderFactory { store: Arc, } impl DefaultParquetFileReaderFactory { + /// Create a factory. pub fn new(store: Arc) -> Self { Self { store } }