Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: format table result vec & remove some unnecessary semicolons #2425

Merged
merged 1 commit into from
May 3, 2022

Conversation

WinkerDu
Copy link
Contributor

@WinkerDu WinkerDu commented May 3, 2022

Which issue does this PR close?

Closes #.

Rationale for this change

As a follow up pr of #2413 , and remove some unnecessary semicolons like

...
        if states.is_empty() {
            return Ok(());
        };    // we can remove this semicolon for code clean
...

What changes are included in this PR?

No.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label May 3, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious why rustfmt isn't finding the semicolons...

@Dandandan
Copy link
Contributor

I'm curious why rustfmt isn't finding the semicolons...

In Rust ; is not meaningless, a block that returns a value no longer has a value after adding ;.

I think rustfmt only knows rust syntax, so this would be more something for rustc/clippy I think. Not sure why the existing lints don´t catch it.

@Dandandan Dandandan merged commit 87940f7 into apache:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants