Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigdecimal crate decimal stringify problem in sqllogictest #9464

Closed
metesynnada opened this issue Mar 5, 2024 · 2 comments · Fixed by #9471
Closed

bigdecimal crate decimal stringify problem in sqllogictest #9464

metesynnada opened this issue Mar 5, 2024 · 2 comments · Fixed by #9471
Labels
bug Something isn't working

Comments

@metesynnada
Copy link
Contributor

Describe the bug

There is a change in sqllogictest float to string method after the bigdecimal crate 0.4.3 version. There are affected PRs like #9460. It will cause an error on every PR status check from now.

To Reproduce

Just run a workflow on CI or local after cargo update.

Expected behavior

No response

Additional context

We should change the cargo.toml as bigdecimal = "=0.4.1" or bigdecimal = "=0.4.2" until it gets a fix.

@metesynnada metesynnada added the bug Something isn't working label Mar 5, 2024
@comphead
Copy link
Contributor

comphead commented Mar 5, 2024

It was okay on my local, lets check CI.

I was experimenting with RUST_BIGDECIMAL_EXPONENTIAL_FORMAT_THRESHOLD but that doesnt seem to wok properly

@metesynnada
Copy link
Contributor Author

maybe you should run cargo update then try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants