Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fetch option from ExternalSorter #9266

Open
yyy1000 opened this issue Feb 19, 2024 · 4 comments
Open

Remove fetch option from ExternalSorter #9266

yyy1000 opened this issue Feb 19, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@yyy1000
Copy link
Contributor

yyy1000 commented Feb 19, 2024

Is your feature request related to a problem or challenge?

When I learn Sort implementation for #9170
I found now the fetch option in ExternalSorter is not used since #7721, see below
https://github.com/apache/arrow-datafusion/blob/497cb9d46c6f68de6762998c241d0860072c7909/datafusion/physical-plan/src/sorts/sort.rs#L868-L897
I wonder whether it's proper to remove this option to make it cleaner or keep it for possible future use.🤔

Describe the solution you'd like

remove the fetch option and related method

Describe alternatives you've considered

Keep it, maybe useful in future?

Additional context

I can help it if needed.

@yyy1000 yyy1000 added the enhancement New feature or request label Feb 19, 2024
@alamb
Copy link
Contributor

alamb commented Mar 3, 2024

Maybe @kazuyukitanimura has some thoughts on this matter

@alamb
Copy link
Contributor

alamb commented Mar 3, 2024

I think removing the option seems to make sense to me if it is not used. We can always put it back

@yyy1000
Copy link
Contributor Author

yyy1000 commented Mar 3, 2024

Thanks! @alamb
I'm also trying to use ExternalSorter in PartialSort to implement spill function. (Still working)
If I find the fetch option will not be used, I can remove it.

@kazuyukitanimura
Copy link
Contributor

It is interesting. We do not have any tests for ExternalSorter.fetch, looks like? @yyy1000
We can remove it but since ExternalSorter.new(..., fetch, ...) is pub, I guess we should add a deprecation message first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants