-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOT operator should not return internal error when args are not boolean value #8965
Comments
Ideally, something early in the code (perhaps the type coercion logic) should return an error if the argument to It looks like perhaps we need to add a clause to Perhaps following the model of As @haohuaijin notes we may want to update https://github.com/apache/arrow-datafusion/blob/e642cc2a94f38518d765d25c8113523aedc29198/datafusion/physical-expr/src/expressions/not.rs#L83-L92 to not check for |
I think this is a good first issue -- the code should be a matter of following existing patterns and ensuring there is some tests for this |
I want try implement this 😄 |
I think we still need check |
Describe the bug
I think the return error message of NOT should like
And
operator, they both only work for boolean value.Originally posted by @haohuaijin in #8957 (comment)
To Reproduce
No response
Expected behavior
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: