Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default filter selectivity estimate configurable #8133

Closed
andygrove opened this issue Nov 10, 2023 · 2 comments · Fixed by #8243
Closed

Make default filter selectivity estimate configurable #8133

andygrove opened this issue Nov 10, 2023 · 2 comments · Fixed by #8243
Labels
enhancement New feature or request

Comments

@andygrove
Copy link
Member

andygrove commented Nov 10, 2023

Is your feature request related to a problem or challenge?

PR #8126 updates FilterExec statistics method so that it will assume that the filter will select 20% of input rows in the case where it is not possible to estimate the output cardinality of the filter.

It would be better to make this configurable, so that users can select a default filter selectivity value between 0.0 (selects no rows) and 1.0 (selects all rows).

Describe the solution you'd like

Add a new configuration option and plumb it through to FilterExec.

Describe alternatives you've considered

No response

Additional context

No response

@edmondop
Copy link
Contributor

@andygrove is this up for grab?

@andygrove
Copy link
Member Author

@andygrove is this up for grab?

@edmondop yes, absolutely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants