Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MemoryReservation should expose MemoryConsumer #7999

Closed
milenkovicm opened this issue Oct 31, 2023 · 0 comments · Fixed by #8000
Closed

MemoryReservation should expose MemoryConsumer #7999

milenkovicm opened this issue Oct 31, 2023 · 0 comments · Fixed by #8000
Labels
enhancement New feature or request

Comments

@milenkovicm
Copy link
Contributor

Is your feature request related to a problem or challenge?

At the moment it looks impossible to implement new MemoryManager outside of datafusion crate as it is impossible to retrieve MemoryConsumer. MemoryConsumer is needed to check if consumer can_spill

Describe the solution you'd like

A new method pub fn consumer(&self) -> &MemoryConsumer to be implemented in MemoryReservation exposing reference to the MemoryConsumer

Describe alternatives you've considered

I have considered exposing Arc<SharedRegistration> instead of MemoryConsumer but it does not have any usefull additional information

Additional context

Relates to #7858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor: Add MemoryReservation::consumer getter milenkovicm/arrow-datafusion-fork
1 participant
@milenkovicm