Ignoring of memory-pool limits & OOM on large cartesian-product join

[DDtKey]

Describe the bug
There is an issue with possible OOM instead of ResourcesExhausted
Probably related to usage of unbounded channels (I believe it should be avoided actually)

To Reproduce

MRE to achieve ignoring of memory-pool with large Cartesian product:

CSV File example (250mb): GDrive link - it's random file and column to join by has the same value for all records (so it's cartesian product)

Memory pool limit: FairSpillPool::new(4 * 1024 * 1024 * 1024)

SQL:
SELECT * FROM rnd rnd1 JOIN rnd rnd2 ON rnd1."s3_drive" = rnd2."s3_drive"

Expected behavior

It should returnResourcesExhausted error with configured MemoryPool

Additional context
Add any other context about the problem here.

A part of this was described in the discussion here: #5108 (comment), but there was mentioned the regression.
This example isn't regression and it's reproducible for old versions

[DDtKey]

I've changed the description, because this case isn't regression like one that was mentioned in #5108 by me. And probably more related to/part of #3941.

[alamb]

I've changed the description, because this case isn't regression like one that was mentioned in #5108 by me. And probably more related to/part of #3941.

Thank you @DDtKey -- I agree this is a feature gap (limiting memory usage by joins)

[korowa]

It seems I was wrong about #5339 closing this issue, my bad 😞 . This query shouldn't produce CROSS JOIN, and memory limitation for hash join required to fix this issue.

[DDtKey]

It seems I was wrong about #5339 closing this issue, my bad 😞 . This query shouldn't produce CROSS JOIN, and memory limitation for hash join required to fix this issue.

Yes, I think so, because this query produces hash-join in plan (or sort merge if enable preference) , but results in Cartesian product actually due to the same values in columns

But anyway it's great that one of the joins is covered 🙂

[korowa]

I guess I'll fix Hash Join using the same approach in a couple of days then 🙃

[alamb]

Thank you @korowa

[Dandandan]

Closed by #5564