Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Raise DataFusionError instead of plain Exceptions #494

Closed
kszucs opened this issue Jun 3, 2021 · 2 comments
Closed

[Python] Raise DataFusionError instead of plain Exceptions #494

kszucs opened this issue Jun 3, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@kszucs
Copy link
Member

kszucs commented Jun 3, 2021

Describe the bug
The library should raise a more specific exception.

To Reproduce
See test case https://github.com/apache/arrow-datafusion/pull/493/files#diff-833d46d402a40f517bfea151178579e3ec772a0da4ce098c0b89867251e6113fR33

@kszucs kszucs added the bug Something isn't working label Jun 3, 2021
@jorgecarleitao
Copy link
Member

I think that we using them already: https://github.com/apache/arrow-datafusion/blob/master/python/src/errors.rs#L25

I think that we just not test them.

@alamb
Copy link
Contributor

alamb commented Nov 2, 2024

Seems like this was solved a while ago -- please reopen / file a new ticket if there is additional work to do. Thanks @drauschenbach for flagging this.

@alamb alamb closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants