Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ballista cannot upgrade to DataFusion 16 due to API changes #4920

Closed
andygrove opened this issue Jan 16, 2023 · 2 comments · Fixed by #4933
Closed

Ballista cannot upgrade to DataFusion 16 due to API changes #4920

andygrove opened this issue Jan 16, 2023 · 2 comments · Fixed by #4933
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

Describe the bug

These fields are now private and Ballista currently depends on accessing and/or mutating them:

  • SessionState.session_id
  • SessionContext.state

To Reproduce
See apache/datafusion-ballista#603

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.
@andygrove andygrove added the bug Something isn't working label Jan 16, 2023
@andygrove andygrove mentioned this issue Jan 16, 2023
Closed
@mingmwang
Copy link
Contributor

@yahoNanJing
Could you please help to take look ?

@yahoNanJing
Copy link
Contributor

Hi @andygrove, you are right. I think we need to patching this before the datafusion dependency upgrade in Ballista.

@yahoNanJing yahoNanJing mentioned this issue Jan 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make it able to specify a session id for SessionState yahoNanJing/arrow-datafusion
3 participants
@andygrove @mingmwang @yahoNanJing