Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projection_push_down adds duplicate projections with multiple passes #3881

Closed
andygrove opened this issue Oct 18, 2022 · 1 comment
Closed

projection_push_down adds duplicate projections with multiple passes #3881

andygrove opened this issue Oct 18, 2022 · 1 comment
Assignees
@andygrove
Labels
bug Something isn't working

Comments

@andygrove
Copy link
Member

Describe the bug

Running the optimizer multiple times inserts redundant projections

Projection: SUM(lineitem.l_extendedprice * lineitem.l_discount) AS revenue
  Aggregate: groupBy=[[]], aggr=[[SUM(lineitem.l_extendedprice * lineitem.l_discount)]]
    Projection: lineitem.l_extendedprice, lineitem.l_discount
      Projection: lineitem.l_extendedprice, lineitem.l_discount
        Projection: lineitem.l_extendedprice, lineitem.l_discount
          Projection: lineitem.l_extendedprice, lineitem.l_discount
            Projection: lineitem.l_extendedprice, lineitem.l_discount

To Reproduce
Run cargo test with #3880

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.
@andygrove andygrove added the bug Something isn't working label Oct 18, 2022
@andygrove andygrove changed the title Multiple projections added with multiple optimizer passes projection_push_down adds duplicate projections with multiple passes Oct 18, 2022
@andygrove andygrove mentioned this issue Oct 18, 2022
Merged
@andygrove andygrove self-assigned this Oct 19, 2022
@andygrove
Copy link
Member Author

Fixed in #3880

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andygrove andygrove

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andygrove