Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization InList: compare the float data type using OrderedFloat<T> #2831

Closed
liukun4515 opened this issue Jul 3, 2022 · 1 comment · Fixed by #4057
Closed

Optimization InList: compare the float data type using OrderedFloat<T> #2831

liukun4515 opened this issue Jul 3, 2022 · 1 comment · Fixed by #4057
Assignees
@liukun4515

Comments

@liukun4515
Copy link
Contributor

Elsewhere in DataFusion (including in ScalarValue) we use ordered_float to compare floating point numbers

It might be possible to use set::<OrderedFloat<f32>>, which would be more space efficient (fewer bytes than ScalarValue) as well as faster (as the comparison doens't have to dispatch on the type each time)

https://github.com/apache/arrow-datafusion/blob/88b88d4360054a85982987aa07b3f3afd2db7d70/datafusion/common/src/scalar.rs#L33

Originally posted by @alamb in #2809 (comment)
@liukun4515 liukun4515 mentioned this issue Jul 3, 2022
Merged
@liukun4515 liukun4515 self-assigned this Jul 4, 2022
@tustvold
Copy link
Contributor

tustvold commented Nov 1, 2022

FYI #4051

@tustvold tustvold mentioned this issue Nov 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liukun4515 liukun4515

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify InListExpr ~20-70% Faster tustvold/arrow-datafusion
2 participants
@tustvold @liukun4515