Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DFSchema serialization does not preserve metadata #1977

Closed
alamb opened this issue Mar 10, 2022 · 0 comments · Fixed by #2001
Closed

DFSchema serialization does not preserve metadata #1977

alamb opened this issue Mar 10, 2022 · 0 comments · Fixed by #2001
Labels
bug Something isn't working

Comments

@alamb
Copy link
Contributor

alamb commented Mar 10, 2022

Describe the bug
As discovered on #1914 #1914 (comment), when a DFSchema is serialized, any name=value metadata is lost

To Reproduce

  1. Try and serialize a DF schema with metadata -- when it is deserialized the metadata will be lost

Expected behavior

  1. Remove the #[allow(deprecated)] added in add metadata to DFSchema, close #1806. #1914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: preserve metadata in proto xudong963/arrow-datafusion
1 participant
@alamb