Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script for running full db-benchmark suite #1870

Closed
matthewmturner opened this issue Feb 22, 2022 · 6 comments · Fixed by #1928
Closed

Add a script for running full db-benchmark suite #1870

matthewmturner opened this issue Feb 22, 2022 · 6 comments · Fixed by #1928
Labels
enhancement New feature or request

Comments

@matthewmturner
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
(This section helps Arrow developers understand the context and why for this feature, in addition to the what)
I've been working on db-benchmark and think it would be valuable to automate the full process so others could run the benchmarks as well

Describe the solution you'd like
A clear and concise description of what you want to happen.
A new shell script in benchmarks/db-benchmark that runs the full db-benchmark process

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@matthewmturner matthewmturner added the enhancement New feature or request label Feb 22, 2022
@matthewmturner
Copy link
Contributor Author

matthewmturner commented Mar 4, 2022

Given that db-benchmark uses R scripts to download the source data im wondering if i should assume that the user will take care of that or if i should wrap this all up in a docker container.

my current preference is wrapping it all up in docker which im thinking should make it easier to use - but i dont have strong feelings either way.

@houqp do you have a preference?

@matthewmturner
Copy link
Contributor Author

@Dandandan also interested in your view on this

@matthewmturner matthewmturner changed the title Add a script for running db-benchmark Add a script for running full db-benchmark suite Mar 4, 2022
@matthewmturner
Copy link
Contributor Author

i just keep forgetting people.

@realno i know you had expressed interest in benchmarking in the past as well so im curious if you have a preference on the above.

@alamb i know youre busy - so no rush - but you had initially raised #147 so interested in your view as well.

@realno
Copy link
Contributor

realno commented Mar 4, 2022

@matthewmturner I like the idea using docker, it should be easier for dependency management.

@houqp
Copy link
Member

houqp commented Mar 9, 2022

agree with @realno , thanks @matthewmturner for taking care of this :)

@matthewmturner
Copy link
Contributor Author

I hope it makes it easier to play with optimizations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants