Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DataFusionError::into_arrow_external_error in favor of From conversion #1644

Closed
alamb opened this issue Jan 22, 2022 · 0 comments · Fixed by #1645
Closed

Remove DataFusionError::into_arrow_external_error in favor of From conversion #1644

alamb opened this issue Jan 22, 2022 · 0 comments · Fixed by #1645
Assignees
Labels
datafusion Changes in the datafusion crate enhancement New feature or request

Comments

@alamb
Copy link
Contributor

alamb commented Jan 22, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The way to convert DataFusionError into an ArrowError is confusing for Rust programmers coming to the DataFusion codebase and makes our codebase a bit of a mess

DataFusionError::into_arrow_external_error

They typically expect a impl From<..> conversion trait

Describe the solution you'd like
Once #1642 is complete, we can remove DataFusionError::into_arrow_external_error and just use ?

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@alamb alamb added the enhancement New feature or request label Jan 22, 2022
@alamb alamb self-assigned this Jan 22, 2022
@alamb alamb added the datafusion Changes in the datafusion crate label Feb 10, 2022
@alamb alamb changed the title Remove non idomatic DataFusionError::into_arrow_external_error in favor of From conversion Remove DataFusionError::into_arrow_external_error in favor of From conversion Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate enhancement New feature or request
Projects
None yet
1 participant