Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decimal support for agg function #1545

Open
4 of 10 tasks
liukun4515 opened this issue Jan 11, 2022 · 4 comments
Open
4 of 10 tasks

decimal support for agg function #1545

liukun4515 opened this issue Jan 11, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@liukun4515
Copy link
Contributor

liukun4515 commented Jan 11, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
The decimal data type has been supported in #122, but in this issue #122 we just support several agg functions.
In this issue we will list some functions which are not implemented for the decimal data type.

TODO

Describe the solution you'd like
A clear and concise description of what you want to happen.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@liukun4515 liukun4515 added the enhancement New feature or request label Jan 11, 2022
@liukun4515
Copy link
Contributor Author

liukun4515 commented Jan 11, 2022

@realno @alamb I add this issue to track agg function which needs to be implemented decimal type.
@realno You have added some agg functions in #1525, I have tracked them.

@realno
Copy link
Contributor

realno commented Jan 12, 2022

@liukun4515 I have added more functions and am planning to add a few in the next few days. Here are the list, please add as tasks:

covar(col1, col2): calculate the covariance (sample) of col1 and col2

covar_samp(col1, col2): calculate the covariance (sample) of col1 and col2

covar_pop(col1, col2): calculate the covariance (population) of col1 and col2

corr(col1, col2): calculate the correlation coefficient (sample) of col1 and col2

corr_samp(col1, col2): calculate the correlation coefficient (sample) of col1 and col2

corr_pop(col1, col2): calculate the correlation coefficient (population) of col1 and col2

median(col1): calculate the median of col1

@liukun4515
Copy link
Contributor Author

e next few da

thanks @realno , I will add them.
You can add the agg functions first, the decimal supporting is not an emergency work.

@liukun4515
Copy link
Contributor Author

@liukun4515 I have added more functions and am planning to add a few in the next few days. Here are the list, please add as tasks:

covar(col1, col2): calculate the covariance (sample) of col1 and col2

covar_samp(col1, col2): calculate the covariance (sample) of col1 and col2

covar_pop(col1, col2): calculate the covariance (population) of col1 and col2

corr(col1, col2): calculate the correlation coefficient (sample) of col1 and col2

corr_samp(col1, col2): calculate the correlation coefficient (sample) of col1 and col2

corr_pop(col1, col2): calculate the correlation coefficient (population) of col1 and col2

median(col1): calculate the median of col1

@realno please check the document of pg https://www.postgresql.org/docs/14/functions-aggregate.html
Some of agg functions don't need to support decimal type, and just need to support double precision data type(double/float64).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants