Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

real data type is float32 in PG database, but in the datafusion it is as float64 #1380

Closed
liukun4515 opened this issue Nov 29, 2021 · 2 comments · Fixed by #1390
Closed

real data type is float32 in PG database, but in the datafusion it is as float64 #1380

liukun4515 opened this issue Nov 29, 2021 · 2 comments · Fixed by #1390
Labels
bug Something isn't working datafusion Changes in the datafusion crate

Comments

@liukun4515
Copy link
Contributor

Describe the bug
In the PG database, the real datatype is as the float32, but it is as float64 in the datafusion.

Do we need to be consistent with PG database in the point?

  1. https://github.com/apache/arrow-datafusion/blob/3bf5811b9a275b7ce6792867a5c1fa230a880742/datafusion/src/catalog/information_schema.rs#L416
  2. https://github.com/apache/arrow-datafusion/blob/414c826bf06fd22e0bb52edbb497791b5fe558e0/datafusion/src/sql/planner.rs#L377

To Reproduce
Steps to reproduce the behavior:

Expected behavior
A clear and concise description of what you expected to happen.

Additional context
Add any other context about the problem here.

@liukun4515
Copy link
Contributor Author

@alamb @houqp do you think we should make consistent with the PG datatype ?

@houqp
Copy link
Member

houqp commented Dec 2, 2021

I think so considering we aim to be compatible with postgres

@alamb alamb added the datafusion Changes in the datafusion crate label Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants