Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate why log.rs bug was not caught by tests #13020

Closed
buraksenn opened this issue Oct 20, 2024 · 1 comment · Fixed by #13034
Closed

Investigate why log.rs bug was not caught by tests #13020

buraksenn opened this issue Oct 20, 2024 · 1 comment · Fixed by #13034
Assignees
Labels
bug Something isn't working

Comments

@buraksenn
Copy link
Contributor

buraksenn commented Oct 20, 2024

Describe the bug

While implementing #12972, I've pushed a commit with a bug for log(x,y) case. However, that CI tests were successful for that commit. Thanks to @berkaysynnada I've realized the bug and fixed it in the PR.

Tests do not cover this case or something else is wrong. I will investigate and fix the issue or extend the tests.

To Reproduce

Reverting the logic in this commit: 58d3d86

This should fail when log function has two arguments (base,value) since value is arg[1] in this case but it does not.

Expected behavior

slt tests or unit tests should have caught the issue.

Additional context

No response

@buraksenn buraksenn added the bug Something isn't working label Oct 20, 2024
@buraksenn
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant