We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add macros for creating WindowUDF and WindowFunction expression from user-defined window functions.
WindowUDF
WindowFunction
This will be similar to existing macros in function aggeregates:
datafusion/datafusion/functions-aggregate/src/macros.rs
Lines 54 to 58 in 80848f2
Existing code which will be replaced by macros:
datafusion/datafusion/functions-window/src/row_number.rs
Lines 35 to 54 in e1b992a
New code using a macro:
define_udwf_and_expr!( RowNumber, row_number, "Returns a unique row number for each row in window partition beginning at 1." );
The above example combines creating both user-defined window function and expression function API. This should work for majority of the cases.
But separate macros will also be provided for cases where they are necessary.
As we begin to convert remaining BuiltinWindowFunction::* to user-defined window functions this will save developer effort.
BuiltinWindowFunction::*
Part of #8709. Follow-on to PR #12030.
Needed for #12649, #12648.
The text was updated successfully, but these errors were encountered:
@SteNicholas Sorry for the confusion. This was unassigned but I already have a PR in the works (#12693).
Here a few more good first issues for user-defined window functions to get you started 😄.
You can reply a single word "take" in the comments of an issue and it will get automatically assigned to you.
See https://datafusion.apache.org/contributor-guide/index.html#open-contribution-and-assigning-tickets
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Is your feature request related to a problem or challenge?
Add macros for creating
WindowUDF
andWindowFunction
expression from user-defined window functions.This will be similar to existing macros in function aggeregates:
datafusion/datafusion/functions-aggregate/src/macros.rs
Lines 54 to 58 in 80848f2
Describe the solution you'd like
Existing code which will be replaced by macros:
datafusion/datafusion/functions-window/src/row_number.rs
Lines 35 to 54 in e1b992a
New code using a macro:
The above example combines creating both user-defined window function and expression function API. This should work for majority of the cases.
But separate macros will also be provided for cases where they are necessary.
Describe alternatives you've considered
As we begin to convert remaining
BuiltinWindowFunction::*
to user-defined window functions this will save developer effort.Additional context
Part of #8709.
Follow-on to PR #12030.
Needed for #12649, #12648.
The text was updated successfully, but these errors were encountered: