Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-equi join (e.g. ON clause) in Dataframe API #1254

Closed
houqp opened this issue Nov 6, 2021 · 0 comments · Fixed by #5210
Closed

Support non-equi join (e.g. ON clause) in Dataframe API #1254

houqp opened this issue Nov 6, 2021 · 0 comments · Fixed by #5210
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@houqp
Copy link
Member

houqp commented Nov 6, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Users should be able to use the Dataframe API to expression the following SQL queries:

SELECT * FROM fact JOIN dim ON fact.x != dim.y;
SELECT * FROM fact JOIN dim ON fact.x > dim.y;
SELECT * FROM fact JOIN dim ON fact.x <= dim.y;
SELECT * FROM fact JOIN dim ON fact.x <> dim.y;

Describe the solution you'd like

Potential solution would be changing the join method to take a list of expressions instead of left_cols and right_cols.

Additional context
Extension of #1135

@houqp houqp added enhancement New feature or request help wanted Extra attention is needed labels Nov 6, 2021
@alamb alamb changed the title Support non-equi join in Dataframe API Support non-equi join (e.g. ON clause) in Dataframe API Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant