Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wrap Arc for AggregateFunctionExpr #12257

Closed
lewiszlw opened this issue Aug 30, 2024 · 1 comment · Fixed by #12353
Closed

Don't wrap Arc for AggregateFunctionExpr #12257

lewiszlw opened this issue Aug 30, 2024 · 1 comment · Fixed by #12353
Assignees
@athultr1997

Comments

@lewiszlw
Copy link
Member 

          If `AggregateFunctionExpr` is not cloned massively, we could remove `Arc`, similar to that we doesn't wrap `Arc` for `Expr`.

Originally posted by @jayzhan211 in #12096 (comment)
@athultr1997
Copy link
Contributor

take

@athultr1997 athultr1997 mentioned this issue Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athultr1997 athultr1997

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed Arc wrapping for AggregateFunctionExpr athultr1997/datafusion
2 participants
@lewiszlw @athultr1997