Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round Robin Polling Between Multiple Winners of Loser Tree in SPM #12231

Closed
berkaysynnada opened this issue Aug 29, 2024 · 2 comments · Fixed by #13133
Closed

Round Robin Polling Between Multiple Winners of Loser Tree in SPM #12231

berkaysynnada opened this issue Aug 29, 2024 · 2 comments · Fixed by #13133
Labels
enhancement New feature or request

Comments

@berkaysynnada
Copy link
Contributor

berkaysynnada commented Aug 29, 2024

Is your feature request related to a problem or challenge?

Assume a scenario where SPM (SortPreservingMergeExec) polls from 3 partitions, each of them gives the same value for the order expression for a very long time. Currently, we poll from the same partition until a new value comes from the other partitions. Continuously polling the same partition gets all upstream operator buffers and channels grow. However, we can execute a round-robin fashioned polling mechanism for the tied partitions.

Describe the solution you'd like

Loser tree can re-order the tied values of partitions.

Describe alternatives you've considered

No response

Additional context

This is the PR resolving a similar problem in the initialization phase: #12230

@berkaysynnada berkaysynnada added the enhancement New feature or request label Aug 29, 2024
@athultr1997
Copy link
Contributor

athultr1997 commented Oct 26, 2024

Continuously polling the same partition gets all upstream operator buffers and channels grow

@berkaysynnada Any idea why this happens ?

@berkaysynnada
Copy link
Contributor Author

@berkaysynnada Any idea why this happens ?

Because of eagerly polling mechanisms like RepartitionExec channels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants