Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Option<Vec<sort expression>> to Vec<sort expression> #12195

Open
findepi opened this issue Aug 27, 2024 · 2 comments
Open

Convert Option<Vec<sort expression>> to Vec<sort expression> #12195

findepi opened this issue Aug 27, 2024 · 2 comments
Assignees

Comments

@findepi
Copy link
Member

findepi commented Aug 27, 2024

Consider AggregateFunction.order_by field -- it is Option<Vec< /*sort expr*/ >>
None means "no sorting" but this can be modeled as Some( vec![] ).
Empty collection perfectly describes lack of sorting, so no need to wrap if with optional value.

Remove Option and keep just Vec.

This can be applied to

  • AggregateFunction.order_by
  • ExprFuncBuilder.order_by
  • ...

based on #12178 (comment) cc @crepererum

@findepi
Copy link
Member Author

findepi commented Aug 27, 2024

take

@findepi
Copy link
Member Author

findepi commented Aug 27, 2024

plan to work on this after #12193, as the two will conflict.

@findepi findepi changed the title Make AggregateFunction.order_by non-Option field Convert Option<Vec<sort expression>> to Vec<sort expression> Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant