You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
let runtime_env = RuntimeConfig::new().with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size))).build();
Describe the solution you'd like
I think a more standard pattern would be of RuntimeConfig was called RuntimeEnvBuilder
Then the example would look like
let runtime_env = RuntimeEnvBuilder::new().with_memory_pool(Arc::new(GreedyMemoryPool::new(pool_size))).build();
Describe alternatives you've considered
I suggest:
Rename RuntimeEnvBuilder to RuntimeConfig
Leave a type alias type RuntimeConfig = RuntimeEnvBuilder to ease upgrades (maybe the typedef could be deprecated with a message to use RuntimeEnvBuilder)
Additional context
No response
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem or challenge?
@theirix added a very nice API in #12151 to simplify RuntimeEnv construction.
However, @comphead pointed out https://github.com/apache/datafusion/pull/12151/files#r1730134993 the names are now somewhat strange that you get a
runtime_env
when creating aRuntimeConfig
objectDescribe the solution you'd like
I think a more standard pattern would be of
RuntimeConfig
was calledRuntimeEnvBuilder
Then the example would look like
Describe alternatives you've considered
I suggest:
RuntimeEnvBuilder
toRuntimeConfig
type RuntimeConfig = RuntimeEnvBuilder
to ease upgrades (maybe the typedef could be deprecated with a message to use RuntimeEnvBuilder)Additional context
No response
The text was updated successfully, but these errors were encountered: