Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sub-project for map udf functions #11572

Closed
zhuliquan opened this issue Jul 20, 2024 · 5 comments
Closed

Add a sub-project for map udf functions #11572

zhuliquan opened this issue Jul 20, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@zhuliquan
Copy link
Contributor

Is your feature request related to a problem or challenge?

No response

Describe the solution you'd like

I notice that code of map/make_map in sub-project functions. Beside, I notice that there is sub-project functions-array for array udf functions. Whether add a sub-project for map udf functions?

Describe alternatives you've considered

No response

Additional context

No response

@zhuliquan zhuliquan added the enhancement New feature or request label Jul 20, 2024
@goldmedal
Copy link
Contributor

Actually, we're discussing moving the map related function to functions-array and renaming this crate to functions-nested in #11546 (comment) because some map implementations are based on make_array. We can have a crate to collect all nested types.

@zhuliquan
Copy link
Contributor Author

Actually, we're discussing moving the map related function to functions-array and renaming this crate to functions-nested in #11546 (comment) because some map implementations are based on make_array. We can have a crate to collect all nested types.

Ok, how long before we can see this crate (i.e. function-nested)? Which crate should contributors submit PR to if they adds UDFs about map now? Or do contributors have to wait until funciotns-nested is available to make corresponding contributions?

@goldmedal
Copy link
Contributor

I plan to move the map UDF to functions-array in #11560 first, and then create another PR to rename functions-array. I guess it is just a renaming task. So, I think the new map-related functions can be put in functions-array currently.
@jayzhan211 WDYT?

@jayzhan211
Copy link
Contributor

I plan to move the map UDF to functions-array in #11560 first, and then create another PR to rename functions-array. I guess it is just a renaming task. So, I think the new map-related functions can be put in functions-array currently.
@jayzhan211 WDYT?

Looks good to me

@zhuliquan
Copy link
Contributor Author

I plan to move the map UDF to functions-array in #11560 first, and then create another PR to rename functions-array. I guess it is just a renaming task. So, I think the new map-related functions can be put in functions-array currently.
@jayzhan211 WDYT?

Looks good to me

Thank you, I got it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants