Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better aggregate support for StringViewArray #11418

Open
XiangpengHao opened this issue Jul 11, 2024 · 2 comments
Open

Better aggregate support for StringViewArray #11418

XiangpengHao opened this issue Jul 11, 2024 · 2 comments
Assignees
@XiangpengHao
Labels
enhancement New feature or request

Comments

@XiangpengHao
Copy link
Contributor

Is your feature request related to a problem or challenge?

Current aggregate makes a special case for Utf8/LargeUtf8 that does not go through the arrow-row format. https://github.com/apache/datafusion/blob/string-view/datafusion/physical-plan/src/aggregates/group_values/mod.rs#L70C4-L81

We should do this to Utf8View/BinaryView as well.

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response
@XiangpengHao XiangpengHao added the enhancement New feature or request label Jul 11, 2024
@XiangpengHao
Copy link
Contributor Author

take

@alamb
Copy link
Contributor

alamb commented Jul 11, 2024

👍 it will probably be a lot simpler for StringView actually (the GroupValuesBytes takes a lot of inspiration from StringView ...)

This was referenced Jul 12, 2024
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XiangpengHao XiangpengHao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alamb @XiangpengHao