Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby bindings #1114

Closed
j-a-m-l opened this issue Oct 14, 2021 · 12 comments
Closed

Ruby bindings #1114

j-a-m-l opened this issue Oct 14, 2021 · 12 comments
Labels
enhancement New feature or request

Comments

@j-a-m-l
Copy link
Contributor

j-a-m-l commented Oct 14, 2021

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
We (me and @kou ) want to implement Ruby bindings for DataFusion.

Describe the solution you'd like
We think that after #1113, we could use the C API to create the Ruby bindings GObject introspection, the same way that Red Arrows does.

Describe alternatives you've considered
Rutie seems simpler, but exposing the C API could be much more beneficial to allow other language bindings.

@j-a-m-l j-a-m-l added the enhancement New feature or request label Oct 14, 2021
@j-a-m-l j-a-m-l mentioned this issue Oct 14, 2021
@jimexist
Copy link
Member

similarly I'm thinking of #1108 and for the moment putting the code here

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Oct 14, 2021

We're going to follow a similar approach: first create a PoC and then, integrate it here if it is accepted.

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Oct 14, 2021

I've seen @jimexist that you've created an issue for upgrading to edition 2021. (edited) I'd like to start with it directly, but it is simpler to just use 2018.

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Oct 24, 2021

I've created a repo: https://github.com/j-a-m-l/datafusion-ruby

In the branch rutie I've also started to try Rutie to integrate Rust in Ruby. Currently the example is very simple and does not include any DataFusion code, but it looks a lot easier than creating the C bindings first.

@jimexist
Copy link
Member

see #1174 @j-a-m-l

@houqp
Copy link
Member

houqp commented Oct 25, 2021

nice work @j-a-m-l, we took the same approach for delta-rs's ruby binding as well :)

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Oct 25, 2021

Thanks @jimexist and @houqp for your comments.

My idea is trying Rutie a little more before deciding if it's a simpler approach than creating the C bindings first and then using them to build the Ruby bindings.

@dsisnero
Copy link

There is another library for ruby bindings to rust - not sure which is more advanced
https://github.com/matsadler/magnus

@j-a-m-l
Copy link
Contributor Author

j-a-m-l commented Jun 13, 2022

Just to clarify: I can't be involved in this binding, since my current employer is not interested and I don't have enough free time to do it.

@kou
Copy link
Member

kou commented Jun 14, 2022

@andygrove Could you create https://github.com/datafusion-contrib/datafusion-ruby and give me admin permission? We can implement Ruby bindings based on https://github.com/datafusion-contrib/datafusion-c .

@andygrove
Copy link
Member

@andygrove Could you create https://github.com/datafusion-contrib/datafusion-ruby and give me admin permission? We can implement Ruby bindings based on https://github.com/datafusion-contrib/datafusion-c .

@kou I have created the repo and sent you an invite.

@kou
Copy link
Member

kou commented Jun 14, 2022

Thanks! Confirmed.

I close this issue. We can use https://github.com/datafusion-contrib/datafusion-ruby for further discussion if it's needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants