Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the arg of octet_length() be a bare Expr instead of Vec<Expr>? #10676

Closed
yutannihilation opened this issue May 26, 2024 · 3 comments · Fixed by #10726
Closed

Should the arg of octet_length() be a bare Expr instead of Vec<Expr>? #10676

yutannihilation opened this issue May 26, 2024 · 3 comments · Fixed by #10726
Labels
bug Something isn't working

Comments

@yutannihilation
Copy link

Describe the bug

This is a minor issue about consistency. Currently, the signature of octet_length() is this, but I think this function takes only one argument just like bit_length().

pub fn octet_length(args: Vec<Expr>) -> Expr

https://docs.rs/datafusion/38.0.0/datafusion/functions/string/expr_fn/fn.octet_length.html

To Reproduce

n/a

Expected behavior

n/a

Additional context

n/a

@yutannihilation yutannihilation added the bug Something isn't working label May 26, 2024
@alamb
Copy link
Contributor

alamb commented May 26, 2024

Yes, I think so -- this is likely an oversight / regression since we moved the functions into a different crate. Thank you for the report

@yutannihilation
Copy link
Author

Thanks for fixing!

@alamb
Copy link
Contributor

alamb commented May 31, 2024

Thanks for fixing!

All credit goes to @marvinlanhenke !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants