New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] make parquet prune tests more readable #10111

Closed

Ted-Jiang opened this issue Apr 17, 2024 · 0 comments · Fixed by #10112

Member

Ted-Jiang commented Apr 17, 2024

          It took me a while to convince myself that this was actually setting up the scenario as described. I eventually found it here:

https://github.com/alamb/arrow-datafusion/blob/dee926519030301f052dc2c3196e4fbef0da4c47/datafusion/core/tests/parquet/mod.rs#L916-L920

I wonder if it would be possible to add some better comments to test_prune mentioning that the created parquet files have 5 rows per page

Originally posted by @alamb in #10051 (comment)

The text was updated successfully, but these errors were encountered:

Ted-Jiang mentioned this issue

[minor] make parquet prune tests more readable #10112

Merged

alamb closed this as completed in #10112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment