Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/datafusion
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 90a2227e6849e96b04d234214268d6135e214952
Choose a base ref
..
head repository: apache/datafusion
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6ffee44c6b3300436a18e667dacdc7ebc36deb45
Choose a head ref
Showing with 4 additions and 4 deletions.
  1. +4 −4 datafusion/optimizer/src/common_subexpr_eliminate.rs
8 changes: 4 additions & 4 deletions datafusion/optimizer/src/common_subexpr_eliminate.rs
Original file line number Diff line number Diff line change
@@ -996,8 +996,8 @@ impl<'n> TreeNodeVisitor<'n> for ExprIdentifierVisitor<'_, 'n> {
TreeNodeRecursion::Jump
}

// In case of `And` and `Or` the first child is surely executed but the count
// the occurrence of subexpressions as conditional in the second.
// In case of `And` and `Or` the first child is surely executed, but we
// account subexpressions as conditional in the second.
Expr::BinaryExpr(BinaryExpr {
left,
op: Operator::And | Operator::Or,
@@ -1010,8 +1010,8 @@ impl<'n> TreeNodeVisitor<'n> for ExprIdentifierVisitor<'_, 'n> {
}

// In case of `Case` the optional base expression and the first when
// expressions are surely executed, but the count the occurrence of
// subexpressions as conditional in the others.
// expressions are surely executed, but we account subexpressions as
// conditional in the others.
Expr::Case(Case {
expr,
when_then_expr,