From 72b81f1f0a5095cc642b91559b0906d6aedf1752 Mon Sep 17 00:00:00 2001 From: Alex Huang Date: Sat, 20 Jan 2024 04:08:39 +0800 Subject: [PATCH] remove null in array-append adn array-prepend (#8901) --- datafusion/physical-expr/src/array_expressions.rs | 6 ------ datafusion/sqllogictest/test_files/array.slt | 6 +++--- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/datafusion/physical-expr/src/array_expressions.rs b/datafusion/physical-expr/src/array_expressions.rs index af6587631df5..b9cdcff20659 100644 --- a/datafusion/physical-expr/src/array_expressions.rs +++ b/datafusion/physical-expr/src/array_expressions.rs @@ -1031,12 +1031,6 @@ where let res = match list_array.value_type() { DataType::List(_) => concat_internal::(args)?, DataType::LargeList(_) => concat_internal::(args)?, - DataType::Null => { - return make_array(&[ - list_array.values().to_owned(), - element_array.to_owned(), - ]); - } data_type => { return generic_append_and_prepend::( list_array, diff --git a/datafusion/sqllogictest/test_files/array.slt b/datafusion/sqllogictest/test_files/array.slt index 55cd17724565..ee9168de6482 100644 --- a/datafusion/sqllogictest/test_files/array.slt +++ b/datafusion/sqllogictest/test_files/array.slt @@ -1599,9 +1599,9 @@ select query ???? select array_append(arrow_cast(make_array(), 'LargeList(Null)'), 4), - array_append(make_array(), null), - array_append(make_array(1, null, 3), 4), - array_append(make_array(null, null), 1) + array_append(arrow_cast(make_array(), 'LargeList(Null)'), null), + array_append(arrow_cast(make_array(1, null, 3), 'LargeList(Int64)'), 4), + array_append(arrow_cast(make_array(null, null), 'LargeList(Null)'), 1) ; ---- [4] [] [1, , 3, 4] [, , 1]