-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ballista python module #58
Conversation
Thank you for the contribution @nl5887. Having a Python repl as part of Ballista will make it much more accessible. Because this builds on the One option may be for us to restore the original |
Nice! This is a great contribution. |
export RUSTFLAGS='-C target-cpu=skylake' | ||
docker run --rm -v $(pwd):/io \ | ||
--workdir /io \ | ||
konstin2/maturin:v0.12.16 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this won't work - it has only 0.12.10 pushed to dockerhub
* Revert "remove python (#1518)" This reverts commit bac97fa. * fix cargo.toml lint issues and exclude from workspace * use original datafusion dependency * fix build * lint
@andygrove rebased this PR on top of #61. The conflicts shows how datafusion-contrib and this python converged. |
Hi @jimexist. Now that we have restored the original DataFusion Python bindings in this repo, would you be willing to create a PR here to submit the improvements that you have made in the datafusion-contrib repo? That will reduce the size of this PR further. We need to be careful not to include changes from contributors that have not yet signed an ICLA but as far as I can see there are just two such commits and they could easily be excluded. If you don't have time to do this would you be ok with me creating the PR with your changes? Thanks. |
Hi @jimexist just in case you missed the previous message. Let me know what your thoughts are, |
Hi @nl5887 Sorry for the delay on this but there have been discussions on the mailing list about this and it turns out that we can just go ahead and PR these changes after all. Would you mind rebasing this PR and I can go ahead and review. Thanks for your patience. |
Rationale for this change
This will introduce the ballista python module, similar to the datafusion python module.