Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find & Eliminate TypeScript Errors That Allow Compiling #878

Open
stricklandrbls opened this issue Oct 3, 2023 · 0 comments
Open

Find & Eliminate TypeScript Errors That Allow Compiling #878

stricklandrbls opened this issue Oct 3, 2023 · 0 comments
Assignees
Labels
build Issues related to building of the code CI Issues related to CI workflows code quality Issues related to code quality data editor Issues related to the Data Editor capability typescript
Milestone

Comments

@stricklandrbls
Copy link
Collaborator

There seems to be a lot of instances where strict types and values are not being implemented and the TS compiler is reporting them as errors in the console. The extension will still compile successfully and build the extension package / run a debug session. If there are errors that are being reported that are actual TS errors then no compilation should succeed.

This also makes it difficult to pinpoint areas of code when there is an actual error that's breaking the extension.

Screenshot of TS errors

image

Note: Errors only seem to be getting reported in VSCode after the TS intellisense has had a change to index through the file. Meaning, errors only get reported after opening a file to edit. I'm assuming this is an artifact from the build system moving completely towards webpack and some files were not opened and generated errors.

@stricklandrbls stricklandrbls added build Issues related to building of the code typescript CI Issues related to CI workflows code quality Issues related to code quality data editor Issues related to the Data Editor capability labels Oct 3, 2023
@stricklandrbls stricklandrbls added this to the 1.4.0 milestone Oct 3, 2023
@nlewis05 nlewis05 moved this from Todo to In Review in daffodil-vscode v1.4.0 Jan 24, 2024
@nlewis05 nlewis05 moved this from In Review to Todo in daffodil-vscode v1.4.0 Jan 24, 2024
@nlewis05 nlewis05 modified the milestones: 1.4.0, 1.5.0 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues related to building of the code CI Issues related to CI workflows code quality Issues related to code quality data editor Issues related to the Data Editor capability typescript
Projects
None yet
Development

No branches or pull requests

2 participants