Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disableHostLookup flag logic #1789

Open
RostislavPorohnya opened this issue Aug 1, 2024 · 0 comments
Open

Fix disableHostLookup flag logic #1789

RostislavPorohnya opened this issue Aug 1, 2024 · 0 comments

Comments

@RostislavPorohnya
Copy link

According to the Contributor comment on #1665 issue:
It seems the behavior was like this since commit 83932d6 that introduced the option. It seems reasonable to me to treat this as a bug since the documentation says that the driver won't try to discover the hosts. Although DisableHostLookup would indeed be better name for a config option like that. And it is not clear to me how users use the DisableInitialHostLookup option, resp. if disabling the lookup always can break someone's program.

Currently, gocql queries system.peers in these cases:

We would need to disable it in all these cases, not just during reconnection.

Originally posted by @martin-sucha in #1665 (comment)

The flag should disable host lookup procedures in cases mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant