Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky TestHealthTrait #5345

Closed
christophd opened this issue Apr 10, 2024 · 2 comments
Closed

Flaky TestHealthTrait #5345

christophd opened this issue Apr 10, 2024 · 2 comments
Labels
area/test/flakiness kind/bug Something isn't working

Comments

@christophd
Copy link
Contributor

What happened?

The E2E test TestHealthTrait is flaky due to failing integration ready condition assertion in health_test.go#L366

The E2E test starts an integration that should never become ready due to health traits. But at some point the Integration condition status is ready=true because for a short term period the Deployment ready state is reflected in the status:

- firstTruthyTime: "2024-04-09T20:36:38Z"
   lastTransitionTime: "2024-04-09T20:36:38Z"
   lastUpdateTime: "2024-04-09T20:36:38Z"
   message: 1/1 ready replicas
   reason: DeploymentReady
   status: "True"
   type: Ready

Shortly after that the Integration controller monitor will set the condition status to ready=false because of the health trait evaluation. This means there is a racing condition on the Integration ready status that causes the test to be flaky

Steps to reproduce

See https://github.com/apache/camel-k/actions/runs/8620813154/job/23630392501?pr=5342

Relevant log output

Camel K installed in namespace test-ce148498-46dd-4778-bf93-496d290c5607 
      health_test.go:366: 
          Failed after 9.120s.
          Expected
              <v1.ConditionStatus>: True
          to equal
              <v1.ConditionStatus>: False

Camel K version

2.3.0

@christophd christophd added the kind/bug Something isn't working label Apr 10, 2024
@squakez
Copy link
Contributor

squakez commented Apr 10, 2024

I think it's a duplicate of #4922

@squakez squakez closed this as not planned Won't fix, can't repro, duplicate, stale Apr 10, 2024
@christophd
Copy link
Contributor Author

@squakez good catch, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test/flakiness kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants