Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-28399] Ensure dataflow experiments are always set when dataflowflow runner is used. #28485

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

robertwb
Copy link
Contributor


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@robertwb
Copy link
Contributor Author

R: @liferoad

Fixes #28399. I verified manually that this makes the repo pass.

@github-actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Merging #28485 (6870283) into master (220cae7) will increase coverage by 0.00%.
Report is 25 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #28485   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files         683      683           
  Lines      100709   100708    -1     
=======================================
+ Hits        72834    72839    +5     
+ Misses      26297    26291    -6     
  Partials     1578     1578           
Flag Coverage Δ
python 82.83% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...on/apache_beam/runners/dataflow/dataflow_runner.py 81.00% <100.00%> (+0.05%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@robertwb robertwb merged commit 52abb14 into apache:master Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants