-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded Dataflow Runner v1 code. #27196
Conversation
Do not merge until after 2.49 is cut. |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Codecov Report
@@ Coverage Diff @@
## master #27196 +/- ##
==========================================
- Coverage 71.62% 71.22% -0.41%
==========================================
Files 855 862 +7
Lines 104225 104627 +402
==========================================
- Hits 74652 74518 -134
- Misses 28026 28562 +536
Partials 1547 1547
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 44 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @AnandInguva |
waiting on author |
it appears there is some unused import breaking pythonlint precommit: https://ci-beam.apache.org/view/PostCommit/job/beam_PreCommit_PythonLint_Cron/5444/console |
Huh. Jenkins was happy with it: https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Commit/20162/ Maybe a race. #27447 |
This is phase 1 of the cleanup.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.