Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded Dataflow Runner v1 code. #27196

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Conversation

robertwb
Copy link
Contributor

This is phase 1 of the cleanup.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@robertwb
Copy link
Contributor Author

R @tvalentyn

Do not merge until after 2.49 is cut.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #27196 (3b0c329) into master (c70eb85) will decrease coverage by 0.41%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master   #27196      +/-   ##
==========================================
- Coverage   71.62%   71.22%   -0.41%     
==========================================
  Files         855      862       +7     
  Lines      104225   104627     +402     
==========================================
- Hits        74652    74518     -134     
- Misses      28026    28562     +536     
  Partials     1547     1547              
Flag Coverage Δ
python 80.41% <92.85%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdks/python/apache_beam/coders/coders.py 87.13% <ø> (+0.08%) ⬆️
...ks/python/apache_beam/coders/coders_test_common.py 98.55% <ø> (-0.03%) ⬇️
sdks/python/apache_beam/coders/row_coder.py 94.01% <ø> (-0.25%) ⬇️
...hon/apache_beam/runners/dataflow/internal/names.py 100.00% <ø> (ø)
...ache_beam/runners/dataflow/ptransform_overrides.py 100.00% <ø> (+1.33%) ⬆️
...on/apache_beam/runners/dataflow/dataflow_runner.py 83.33% <85.71%> (+1.86%) ⬆️
...apache_beam/runners/dataflow/internal/apiclient.py 75.63% <100.00%> (-1.39%) ⬇️

... and 44 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

Reminder, please take a look at this pr: @AnandInguva

@tvalentyn
Copy link
Contributor

waiting on author

@robertwb
Copy link
Contributor Author

Huh. Jenkins was happy with it: https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Commit/20162/ Maybe a race. #27447

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants