Adds an SdkHarnessOption that controls whether logging is redirected through the FnApi #33418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hrough the FnApi logging service. Redirection through the logging service is enabled by default.
…hrough the FnApi logging service. Redirection through the FnApi is enabled by default.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
kennknowles
reviewed
Jan 2, 2025
sdks/java/core/src/main/java/org/apache/beam/sdk/options/SdkHarnessOptions.java
Show resolved
Hide resolved
|
Assigning reviewers. If you would like to opt out of this review, comment R: @kennknowles for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
the option to 'enabled'.
|
I checked the test failures and they looked like flakes. I retried the failed jobs. |
Abacn
approved these changes
Jan 7, 2025
|
I believe the legacy work test failures are unrelated. It does not depend on java harness and vice versa |
stankiewicz
pushed a commit
to stankiewicz/beam
that referenced
this pull request
Jan 16, 2025
…through the FnApi (apache#33418) * Add an SdkHarnessOption that controls whether logging is redirected through the FnApi logging service. Redirection through the logging service is enabled by default. * Add an SdkHarnessOption that controls whether logging is redirected through the FnApi logging service. Redirection through the FnApi is enabled by default. * include license in new files * fix ManagedChannel dep * fix invalid conversions * fix missing imports * fix type mismatch * fix up tests * continue to use anyOf when logViaFnApi is enabled * More comments on the new SdkHarnessOption. DataflowRunner.run() forces the option to 'enabled'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an SdkHarnessOption that controls whether logging is redirected through the FnApi logging service. Redirection through the FnApi is enabled by default.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.