Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apache snapshot repo usage #33370

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Fix Apache snapshot repo usage #33370

merged 2 commits into from
Dec 13, 2024

Conversation

adoroszlai
Copy link
Contributor

What changes were proposed in this pull request?

Problem: Beam build searches repository.apache.org for artifacts not to be found there. (See also #33333.)

Repro:

$ rm -fr ~/.gradle/caches
$ ./gradlew --info sdks:java:io:kafka:compileJava
...
Resource missing. [HTTP GET: https://repository.apache.org/snapshots/io/confluent/kafka-avro-serializer/7.5.5/kafka-avro-serializer-7.5.5.pom]
Resource missing. [HTTP GET: https://repository.apache.org/snapshots/io/confluent/kafka-schema-registry-client/7.5.5/kafka-schema-registry-client-7.5.5.pom]
Resource missing. [HTTP GET: https://repository.apache.org/content/repositories/releases/io/confluent/kafka-schema-registry-client/7.5.5/kafka-schema-registry-client-7.5.5.pom]
Resource missing. [HTTP GET: https://repository.apache.org/content/repositories/releases/io/confluent/kafka-avro-serializer/7.5.5/kafka-avro-serializer-7.5.5.pom]
...

Fix:

  1. Limit repository.apache.org/snapshots to snapshot artifacts.
  2. Move Confluent repo definition before the Apache repos.

How was this patch tested?

$ rm -fr ~/.gradle/caches
$ ./gradlew --info sdks:java:io:kafka:compileJava | tee gradle.log 2>&1

$ grep -c 'HTTP GET.*repository.apache.org' gradle.log
0

$ grep 'packages.confluent' gradle.log
Downloading https://packages.confluent.io/maven/io/confluent/kafka-schema-registry-client/7.5.5/kafka-schema-registry-client-7.5.5.pom to ...
Downloading https://packages.confluent.io/maven/io/confluent/kafka-avro-serializer/7.5.5/kafka-avro-serializer-7.5.5.pom to ...
...

@github-actions github-actions bot added the build label Dec 12, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@adoroszlai
Copy link
Contributor Author

assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@Abacn Abacn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks for the fix!

@Abacn Abacn merged commit 994d2f0 into apache:master Dec 13, 2024
21 checks passed
@adoroszlai adoroszlai deleted the snapshots-only branch December 13, 2024 14:16
@adoroszlai
Copy link
Contributor Author

Thanks @Abacn for reviewing and merging this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants