-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Iceberg to v1.6.1 #33294
Bump Iceberg to v1.6.1 #33294
Conversation
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
assign set of reviewers |
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Reminder, please take a look at this pr: @robertwb @johnjcasey |
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn for label java. Available commands:
|
abdcb0c
to
ef837b1
Compare
ef837b1
to
384d549
Compare
Hi @ahmedabu98 thanks for taking a look! let me know if smth else is missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Out of curiosity, what motivated this version upgrade?
@ahmedabu98 I was not hitting any particular issue in specific. Trying to keep things updated since between 1.4.3 and 1.6.1, parquet support, table scan's have been improved and there's some spec additions. |
Sounds good 👍🏽 merging now. Thanks for tagging me on your other PRs, I'll take a look at them later today. Can you resolve their conflicts and similarly trigger the integration tests too? |
We can't bump to v1.7.0 as java 8 support was dropped.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.