Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump yapf from 0.29.0 to 0.43.0 in /sdks/python #33112

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 14, 2024

Bumps yapf from 0.29.0 to 0.43.0.

Changelog

Sourced from yapf's changelog.

Change Log

All notable changes to this project will be documented in this file.

This project adheres to Semantic Versioning.

(0.41.0) UNRELEASED

Added

  • New DISABLE_SPLIT_LIST_WITH_COMMENT flag. DISABLE_SPLIT_LIST_WITH_COMMENT is a new knob that changes the behavior of splitting a list when a comment is present inside the list.

    Before, we split a list containing a comment just like we split a list containing a trailing comma: Each element goes on its own line (unless DISABLE_ENDING_COMMA_HEURISTIC is true).

    This new flag allows you to control the behavior of a list with a comment separately from the behavior when the list contains a trailing comma.

    This mirrors the behavior of clang-format, and is useful for e.g. forming "logical groups" of elements in a list.

    Without this flag:

    [
      a,
      b,  #
      c
    ]
    

    With this flag:

    [
      a, b,  #
      c
    ]
    

    Before we had one flag that controlled two behaviors.

    • DISABLE_ENDING_COMMA_HEURISTIC=false (default):
      • Split a list that has a trailing comma.
      • Split a list that contains a comment.
    • DISABLE_ENDING_COMMA_HEURISTIC=true:
      • Don't split on trailing comma.
      • Don't split on comment.

    Now we have two flags.

... (truncated)

Commits
  • 5cb90cb Bump version to v0.43.0
  • 29db8b7 Actions(deps): Bump actions/checkout from 4.2.0 to 4.2.1 (#1249)
  • 89d1cd0 Actions(deps): Bump peter-evans/create-pull-request from 6.0.2 to 7.0.5 (#1239)
  • 7e21823 ylib2to3/pgen2/grammar: Fix Grammar.dump for parallel use with Grammar.load (...
  • ed70540 pre-commit: Add hook for yapf-diff (#1246)
  • 0de7684 Actions(deps): Bump actions/checkout from 4.1.2 to 4.2.0 (#1241)
  • b951457 Fix CI (#1242)
  • 1afbf71 Actions(deps): Bump actions/setup-python from 5.0.0 to 5.1.0 (#1218)
  • fcd79bc Actions(deps): Bump peter-evans/create-pull-request from 6.0.0 to 6.0.2 (#1213)
  • 507a900 Actions(deps): Bump actions/checkout from 4.1.1 to 4.1.2 (#1212)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file python labels Nov 14, 2024
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@claudevdm
Copy link
Contributor

@damccorm do you know if this PR is still valid?

@damccorm
Copy link
Contributor

damccorm commented Jan 7, 2025

@damccorm do you know if this PR is still valid?

It should be, updating this dep seems valid. Usually with dependabot I:

  1. Check if the change is reasonable
  2. Make sure we get green checks - in this case we have red statuses, but I can't tell if its because of flakes or not so I'll get dependabot to rebase/rerun checks
  3. Merge if green
  4. Close if not - I don't worry too much about this since dependabot will open a new pr for newer versions and we can also manually bump versions which need special attention

@damccorm
Copy link
Contributor

damccorm commented Jan 7, 2025

@dependabot rebase

Bumps [yapf](https://github.com/google/yapf) from 0.29.0 to 0.43.0.
- [Changelog](https://github.com/google/yapf/blob/main/CHANGELOG.md)
- [Commits](google/yapf@v0.29.0...v0.43.0)

---
updated-dependencies:
- dependency-name: yapf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/sdks/python/yapf-0.43.0 branch from 49b6278 to 3c001e6 Compare January 7, 2025 14:38
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @tvalentyn for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@damccorm damccorm merged commit 1b78b67 into master Jan 7, 2025
94 checks passed
@dependabot dependabot bot deleted the dependabot/pip/sdks/python/yapf-0.43.0 branch January 7, 2025 16:02
jrmccluskey pushed a commit to jrmccluskey/beam that referenced this pull request Jan 8, 2025
Bumps [yapf](https://github.com/google/yapf) from 0.29.0 to 0.43.0.
- [Changelog](https://github.com/google/yapf/blob/main/CHANGELOG.md)
- [Commits](google/yapf@v0.29.0...v0.43.0)

---
updated-dependencies:
- dependency-name: yapf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Next Action: Reviewers python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants